intellij-csv-validator icon indicating copy to clipboard operation
intellij-csv-validator copied to clipboard

Row height seems to be broken in 3.0

Open trinhanhngoc opened this issue 2 years ago • 7 comments

After installing the latest version 3.0.1 on PyCharm 2022.23 (Mac OS), row height in table editor is too small, default row height in Settings has no effect.

image image

trinhanhngoc avatar Nov 14 '22 10:11 trinhanhngoc

Both, row height and column width defaults, are measured in px. I will add the unit to the settings.

Furthermore, in the table editor the row height can be adjusted by dragging the row lines on the left side (row counts), similar to changing the column width.

SeeSharpSoft avatar Nov 14 '22 13:11 SeeSharpSoft

@SeeSharpSoft Thank for the info. Another question: How to reset row height value in a file to the default value in setting?

trinhanhngoc avatar Nov 14 '22 14:11 trinhanhngoc

Update: I just noticed that the previous row height setting might be taken into account, which was not the row height in px but but the number of row lines. I will fix this.

SeeSharpSoft avatar Nov 14 '22 14:11 SeeSharpSoft

How to reset row height value in a file to the default value in setting?

There is no option for this, but it should be quite uncomplicated to adjust the row height for a file manually to your likings. The default value is 48px (usually like 2 row lines).

SeeSharpSoft avatar Nov 14 '22 14:11 SeeSharpSoft

How to reset row height value in a file to the default value in setting?

There is no option for this, but it should be quite uncomplicated to adjust the row height for a file manually to your likings. The default value is 48px (usually like 2 row lines).

Ok. Thank you very much!. My plugin depends on your plugin for some features in CSV files. I plan to do some PRs for your plugin to make the integration better for features like code completion, reference navigation,... I hope you accept it.

trinhanhngoc avatar Nov 14 '22 14:11 trinhanhngoc

Sounds good - looking forward to it! Just make sure to check CONTRIBUTING.md - thanks!

SeeSharpSoft avatar Nov 14 '22 14:11 SeeSharpSoft

In a similar vein is there a way you could set the row height to be 150% so its a percentage of the font size, that way it will adjust for us and we could do either % or total pixel size so we don't have to futz with the settings except once.

Screen Shot 2023-02-03 at 9 24 18 AM

datatalking avatar Feb 03 '23 17:02 datatalking