intellij-csv-validator icon indicating copy to clipboard operation
intellij-csv-validator copied to clipboard

Show diff opens an empty window

Open rala72 opened this issue 4 years ago • 10 comments
trafficstars

If I open a diff window the first time in a project and it is a CSV file the CSV editor opens an empty window. Afterwards I am not able to open any diff anymore - including other file types - the CSV diff always shows an empty file. The only solution I found yet is restarting the project.

If I open a diff on another file first the basic diff window opens also on CSV files.

Honestly not sure if this an issue of that plugin but I think so (sorry if not).

rala72 avatar Sep 30 '21 09:09 rala72

Thanks for reporting - unfortunately I either don't understand the issue correctly, or I cannot reproduce it.

What do you mean by "open a diff window"? Is it the option EditorContextMenu -> Git -> Show Diff, or FileContextMenu -> Compare With...? Both options seem to work fine.

You could just disable the plugin (and restart IDE) to check whether the issue persists. If this fixes the issue, then please give a more detailed description of the steps, or add a screen-capture to this issue, so I can hopefully reproduce it.

SeeSharpSoft avatar Oct 02 '21 06:10 SeeSharpSoft

Sorry for being unclear; yes, after unloading the plugin the issue is gone.

I'm meaning the option Git-Tool window -> Log -> Commit Content -> ContextMenu -> Show Diff. As far as I tried all other options work, but the way listed above breaks all the same kind. (I can't provide a screenshot, because it is my business project and I was not able to reproduce it on a private one yet).

rala72 avatar Oct 04 '21 06:10 rala72

Thanks for the clarification.

Unfortunately I am not able to reproduce it locally, even when following the path you noted down directly after starting the IDE.

Can you provide IDE type (IDEA, WebStorm, PyCharm, etc.), version, Java version and your operating system (Win/Mac/Linux/...) please. Thanks!

SeeSharpSoft avatar Oct 04 '21 15:10 SeeSharpSoft

Windows 10 Java AdoptOpenJDK (build 11.0.10+9, 64bit) IDEA Ultimate; 2021.2.2 (212.5284.40)

Below a screenshot of the dialog that pops up (the git log is partly seen in the background): screenshot It never also stops indexing (IJ already stopped indexing).

rala72 avatar Oct 05 '21 06:10 rala72

Thanks for the detailed description and the screenshot. I actually couldn't reproduce the same behavior (the diff screen looks slightly different for me, and it was always actually showing the correct diff), but I noticed the "Text" and "Table Editor" tabs on the bottom of the editor window - which do not belong there in the diff window. I will check on this!

SeeSharpSoft avatar Oct 21 '21 15:10 SeeSharpSoft

I updated to the recent version:

I still see the tabs below but I can also see the diff:

text: text diff: diff

rala72 avatar Oct 22 '21 11:10 rala72

Thanks for sharing. There is no "Table Editor" tab anymore - and I used the very same check for the "Text" editor to prevent it during diff-view. So I'd claim that this "Text" editor tab is not related to this plugin.

I noticed in your previous screenshot an icon that doesn't is this plugins CSV icon. Do you have any other plugin installed that takes care of CSV files? Can you once again check the behavior while the CSV plugin is disabled? For me it does behave as expected now.

SeeSharpSoft avatar Oct 22 '21 11:10 SeeSharpSoft

I disabled it now and the "Text" tab is gone.

disabled

Do you mean the fancy CSV icon? It is just the Extra Icons plugin.

rala72 avatar Oct 22 '21 11:10 rala72

This is how it looks for me!! 🙈 I am again clueless... suggestions are welcome!

PS: Yes, the "fancy CSV icon" - didn't know about the "Extra Icons" plugin, thanks!

SeeSharpSoft avatar Oct 22 '21 11:10 SeeSharpSoft

I have no idea right now too. At least I can see the diff - that's the most important part.

I'd leave the issue open, because we might find a solution later.

rala72 avatar Oct 22 '21 12:10 rala72