EIP-Spec icon indicating copy to clipboard operation
EIP-Spec copied to clipboard

xByPartition argument order

Open ijxy opened this issue 7 years ago • 0 comments

The proposed signature is

xByPartition(bytes32 _partition, <usual args for x>)

but this feels unintuitive because it should build on x, i.e., it is x with an extra argument to specify a parttion. Hence I would instead propose

xByPartition(<usual args for x>, bytes32 _parttion)

Although the above is explicitly targeted at the xByPartition functions, it applies equally to any functions that follow the xByY. So, generally, I am suggesting: xByY(<usual x args>, <y specific args>).

ijxy avatar Dec 12 '18 13:12 ijxy