Bartosz Sokorski comments

Results 308 comments of


                                            Bartosz Sokorski

Cleo 3.0 writeup

@ironbars checkout #440.

Optionally don't write a RECORD file

Personally, I don't think we should do that. I understand that some Linux distributions might delete that file, but it is part of the standard, and adding an option to...

Optionally don't write a RECORD file

@pradyunsg your opinion? I think it wouldn't be a good option to add.

Includes do not seem to work correctly

Please tone down @tallero, @dimbleby

Includes do not seem to work correctly

@tallero 1. As dimbleby pointed out, you are using the wrong build backend (you define `poetry >=0.12` and `poetry.masonry.api`, while proper values should be `poetry-core >= 1.x` (x being whatever...

poetry install on GitHub actions fails with python version mismatch

Fixed on main

fix: keep lock file eol

Could you please make the fix in [`tomlkit`](https://github.com/python-poetry/tomlkit) instead? Sounds like it belongs there more than Poetry code.

fix: keep lock file eol

Well, if it was fixed in tomlkit, we wouldn't need this patch, right? For me, this sounds like a workaround at best.

fix: keep lock file eol

I still believe that this should be fixed in `tomlkit` not here

Fix parse invalid interval string

Please rebase your changes with master to fix the failing pipeline