mjml-net icon indicating copy to clipboard operation
mjml-net copied to clipboard

Request for .net core version

Open Abenezer opened this issue 1 year ago • 2 comments

I am impressed by the performance and not having to request online service. but we couldnt work on production because we use .net core. is there any chance you port the library to .net core or .net standard?

Thankyou

Abenezer avatar Dec 06 '23 05:12 Abenezer

Not sure, We use a lot of modern features. It is probably possible but you will not achieve the same performance. PRs are welcome

SebastianStehle avatar Dec 06 '23 10:12 SebastianStehle

I have no plans to work on this myself. If you need it you have to provide a PR.

SebastianStehle avatar Jan 12 '24 17:01 SebastianStehle

I have a working branch for net472, mostly solved by using the Polyfill NuGet. Had to add a couple pragmas and turn IType into an abstract class, since default implementations in interfaces is not supported.

It's certainly significantly slower, but not necessarily prohibitively so (about 2x). Also, I haven't really dug into optimizing things. Just wanted to make it compile and get green tests.

gliljas avatar Jun 12 '24 16:06 gliljas

Closed due to inactivity

SebastianStehle avatar Jul 23 '24 20:07 SebastianStehle