journalctl-mode icon indicating copy to clipboard operation
journalctl-mode copied to clipboard

Please update license version in header, conflicts with LICENSE file

Open tarsius opened this issue 2 years ago • 1 comments

Please update the permission statement. I recommend you use the standard permission statement:

;; This file is free software: you can redistribute it and/or modify
;; it under the terms of the GNU General Public License as published
;; by the Free Software Foundation, either version 3 of the License,
;; or (at your option) any later version.
;;
;; This file is distributed in the hope that it will be useful,
;; but WITHOUT ANY WARRANTY; without even the implied warranty of
;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
;; GNU General Public License for more details.
;;
;; You should have received a copy of the GNU General Public License
;; along with this file.  If not, see <https://www.gnu.org/licenses/>.

Additionally it would be nice if you could add a license header, for easier parsing:

;; SPDX-License-Identifier: GPL-3.0-or-later

Thanks!

This will allow us to continue to distribute this package on Melpa.

/cc @riscy

tarsius avatar Mar 20 '22 14:03 tarsius

To be clear, the permission statement in the library currently says this is licensed under the GPLv2 (not "GPLv2 or a later version"). This is incompatible with the license used by Emacs (>= GPLv3). Please fix that so we don't have to remove this package from Melpa. Thanks!

tarsius avatar Aug 17 '22 09:08 tarsius

The license of elisp packages have to be compatible with that of Emacs and GPL-2.0 is not compatible with GPL-3.0. While it appears that you intended to use GPL-3.0, since you included that license file, the permission statement actually says v2, and that overrides the license file as it is more local. Please correct that soon or I will be forced to remove this package from Melpa and the Emacsmirror.

tarsius avatar Sep 29 '22 22:09 tarsius

I have now removed the package from Melpa.

tarsius avatar Nov 02 '22 21:11 tarsius

I updated the Licence file, please resubmit to melpa.

SebastianMeisel avatar Nov 14 '22 07:11 SebastianMeisel

Thanks!

The removal has been reverted.

tarsius avatar Nov 14 '22 11:11 tarsius

It seems there was a misunderstanding.

  1. We can only distribute packages on Melpa whose licenses are compatible with those of GNU Emacs.
  2. Emacs is released under version 3 of the GPL.
  3. Previously it was unclear whether your package is released under version 2 or 3 of the GPL.
  4. You have clarified that now. It is released under version 2 of the GPL.
  5. Therefore the license of this package is not compatible with that of Emacs and it therefore has to removed from Melpa again.

Since you asked me to resubmit this to Melpa, I am guessing that this was not your intention.

If that is so, then you have to do these things.

  1. Revert the change to the LICENSE file, so that it contains the text of version 3 again.
  2. Remove this from journal-mode.el:
    ;; You can redistribute this program and/or modify it under the terms of the GNU General Public License version 
    
  3. Add this instead:
    ;; This file is free software: you can redistribute it and/or modify
    ;; it under the terms of the GNU General Public License as published
    ;; by the Free Software Foundation, either version 3 of the License,
    ;; or (at your option) any later version.
    ;;
    ;; This file is distributed in the hope that it will be useful,
    ;; but WITHOUT ANY WARRANTY; without even the implied warranty of
    ;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    ;; GNU General Public License for more details.
    ;;
    ;; You should have received a copy of the GNU General Public License
    ;; along with this file.  If not, see <https://www.gnu.org/licenses/>.
    

If I guessed wrong, then please explicitly tell me that it is your intention to release this under the terms of version 2 of the GPL and only that version. I will then remove it from Melpa again.

tarsius avatar Nov 14 '22 20:11 tarsius

Hello,

sorry it took so long. I'm now back on GPL v.3 with the appropriate text in the *.el.

Greetings

Sebastian

Am Mo., 14. Nov. 2022 um 21:19 Uhr schrieb Jonas Bernoulli < @.***>:

It seems there was a misunderstanding.

  1. We can only distribute packages on Melpa whose licenses are compatible with those of GNU Emacs.
  2. Emacs is released under version 3 of the GPL.
  3. Previously it was unclear whether your package is released under version 2 or 3 of the GPL.
  4. You have clarified that now. It is released under version 2 of the GPL.
  5. Therefore the license of this package is not compatible with that of Emacs and it therefore has to removed from Melpa again.

Since you asked me to resubmit this to Melpa, I am guessing that this was not your intention.

If that is so, then you have to do these things.

  1. Revert the change to the LICENSE file, so that it contains the text of version 3 again.
  2. Remove this from journal-mode.el:

;; You can redistribute this program and/or modify it under the terms of the GNU General Public License version

  1. Add this instead:

;; This file is free software: you can redistribute it and/or modify ;; it under the terms of the GNU General Public License as published ;; by the Free Software Foundation, either version 3 of the License, ;; or (at your option) any later version. ;; ;; This file is distributed in the hope that it will be useful, ;; but WITHOUT ANY WARRANTY; without even the implied warranty of ;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the ;; GNU General Public License for more details. ;; ;; You should have received a copy of the GNU General Public License ;; along with this file. If not, see https://www.gnu.org/licenses/.

If I guessed wrong, then please explicitly tell me that it is your intention to release this under the terms of version 2 of the GPL. I will then remove it from Melpa again.

— Reply to this email directly, view it on GitHub https://github.com/SebastianMeisel/journalctl-mode/issues/18#issuecomment-1314327155, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALURSNI7JAKDAR2W5KQ2Y6DWIKNEXANCNFSM5RFSTLZA . You are receiving this because you commented.Message ID: @.***>

SebastianMeisel avatar Nov 19 '22 09:11 SebastianMeisel

Looks good now. Thanks!

tarsius avatar Nov 20 '22 17:11 tarsius