Digital-Logic-Sim icon indicating copy to clipboard operation
Digital-Logic-Sim copied to clipboard

Feat: Set Group Size

Open sagitarious12 opened this issue 4 years ago • 4 comments

This PR adds a button on the left side just above where the input pins are which allows for setting the group size in game. Group sizing was built but it was inaccessible to those that downloaded the game without source code.

This PR also upgrades the unity editor version.

showing the button location. Button Location

the form modal popup. Form Modal

the ability to change the group size in game completed. Result

sagitarious12 avatar Mar 24 '21 06:03 sagitarious12

This is a great addition, especially for if we ever get a mobile port. I tried hacking one together but it's really not good with normal mouse controls and still no zoom function. Thanks for adding to the program!

okyloky9 avatar Mar 25 '21 13:03 okyloky9

This absolutely needs a cap for the group size. Right now you can put numbers that don't even fit in the UI and then freeze the program if you try to place a group that is way too big

CyberPhoenix90 avatar Apr 12 '21 19:04 CyberPhoenix90

@CyberPhoenix90 That is very true. I will update the PR and push it in very soon. Thanks for the QA check! Any suggestion on what the limit should be set to? I was think 8 would be good. but I would like your opinion. I will set the code the 8 for now and update if it should be changed.

sagitarious12 avatar Apr 12 '21 19:04 sagitarious12

Considering that using +/- to create groups you are limited to 8 I think it's very reasonable to have the same limit here

CyberPhoenix90 avatar Apr 12 '21 20:04 CyberPhoenix90