Sebastian Krantz

Results 113 comments of Sebastian Krantz

Hi @adamhsparks. Thanks for these initial comments. Let me work a bit further on it still to ensure the package passes your checks as good as possible and we can...

I have now brought *dfms* to a state where I am happy with it. The software is quite robust and inputs are rigorously checked. I still get some *autotest* issues,...

Thanks @adamhsparks for the clarification. I will then open an issue requesting review, and also prepare a first CRAN release.

Yes, `collapse` does not perform any 'spatial' operations, you need to use `st_make_valid()` or similar if this is important to your application.

Just to be clear conceptually: the reason *collapse* is so fast is because I do almost everything at C-level without calling other functions or methods present at the R level....

Thanks, I will look into this next week, but at first sight this does not appear to be a code issue. integer64 is stored as double in R, the GCD...

I've tried to code something specific for integer64, but I haven't really been able to figgure out how the values of the object behave, or how they are represented in...

Better: New argument `keep`, `drop` or similar to generate the index with integer levels.

Also could think of conflict management mechanism / user preferences.

*collapse* provides verbosity for critical operations such as joins (and, optionally, for pivots using the `check.dups` argument to `pivot`). It also prints informative statistics below grouped/indexed data frames. I don't...