collapse icon indicating copy to clipboard operation
collapse copied to clipboard

Contributing enhancements

Open alinacherkas opened this issue 10 months ago • 4 comments

Description

This request enhances the developer's experience and streamlines the contributing process by adding renv and extending the contributing guidelines.

Main Changes

  • Configure the project to use renv which isolates the developer's environment
  • Detail how to contribute to the project in contributing guidelines
  • Update .gitignore using the modern GitHub template for R projects

Checklist

  • [x] I have performed a self-review of my code.
  • [x] I have commented on my code, particularly in hard-to-understand areas.
  • [x] I have updated the documentation where applicable.

Additional Context

None.

alinacherkas avatar Feb 25 '25 10:02 alinacherkas

Thanks @alinacherkas. I'm wondering though, I presume it is still possible to contribute in the classical way? If people have to install renv to contribute to collapse (which frankly I haven't used myself all the years), it may make it more difficult to do so?

SebKrantz avatar Feb 26 '25 10:02 SebKrantz

Hi @SebKrantz, actually, installation is not even necessary these days. According to renv documentation:

Now when one of your collaborators opens this project, renv will automatically bootstrap itself, downloading and installing the appropriate version of renv.

I have already verified this on another device and removed the note from CONTRIBUTING.md.

renv's main benefit is that all the packages (testthat, plm and other packages under Suggests) are installed in an isolated environment. Additionally, you can easily upgrade all the packages with renv::update() for testing before releasing to CRAN.

You don't really have to do much to use renv in this case. One can just open .Rproj and work the usual way.

alinacherkas avatar Feb 26 '25 19:02 alinacherkas

Ok, thanks. I'll test this on your fork during the weekend - it's not a small change to the repo and I need to ensure myself and others can work without problems with it - even using VScode and other tools.

SebKrantz avatar Feb 26 '25 22:02 SebKrantz