Sebastian Günther

Results 139 comments of Sebastian Günther
trafficstars

I have updated the data structure as mentioned above. Only, I decided to store models and results within lists instead of dicts for now. Respective getter methods are already in...

Hello Pierre, Thank you for your feedback! I will go though it. > Here are few questions/tough that I have regarding your new module: > > During recent work and...

Hello Pierre, I am realy realy unsure, if I completely understood your proposals on linking laminations and models. I am even not sure if this is needed anyway. I did...

Hello Pierre, I implemented two main changes. First, the iron loss model now uses the index of the lamination as you suggested. Second, I split the OutLoss.losses property (i.e. the...

Thank you for your feedback Pierre. I will implement my idea, that may allow reproducability in my optinion. We will see if this is too fancy :-) (I was thinking...

Hello, I'm planing to PR the Loss feature quite soon. Does someone (@BonneelP ?) has ready to use machines (json) with respective reference losses for validation? BR Sebastian

I decided to finally PR my work on this issue although there are still a lot of TODOs. #286

Hello Pierre, thank you very much for this commit. As allways I've got something to complain. I hope you don't mind. :-) I think it would be good idea to...

Hello Pierre, I had a look at the GUI and since it is the first release, there are still some things to do. What do you think, should we collect...

Hello Pierre, I know some of the following things are worth new issues, I first list them here and we can decide. - [ ] axial vent. duct preview window...