Seaside icon indicating copy to clipboard operation
Seaside copied to clipboard

`WAExternalFileUploadCallback` logic should be moved to the adaptors

Open jbrichau opened this issue 9 years ago • 4 comments

The request handling logic that is now in WAExternalFileUploadCallback should be moved to the adaptor framework. This is also where 'normal' WAFile instances are created in the request conversion. This will probably also enable to create a WAFile or WAExternalFile instance depending on if the request contains the file or the metadata of the file location. We might then be able to transparently work with external file upload callbacks, only loading the file contents when it was explicitly asked for.

jbrichau avatar Aug 27 '16 08:08 jbrichau

Where do I find WAExternalFileUploadCallback?

marschall avatar Aug 27 '16 12:08 marschall

It's in Seaside-ExternalFileUpload package. See here for more info on what it is.

I'll take care of it. I was fixing a bug and noticed it could be done more elegantly, which is what this issue is about to remind me.

jbrichau avatar Aug 27 '16 13:08 jbrichau

I have a working hack wich I'm currently discussing with Sven. What I have in mind should:

  1. allow a proxy server to handle the file upload
  2. enable Seaside (or Zinc, depending on what Sven thinks) to write the upload to a temporary file on disk

theseion avatar May 27 '17 17:05 theseion

On 2. I think it's better to have Zinc (or the whatever the server is) do it rather than Seaside. In order to avoid loading everything into memory Seaside would have to operate on a stream. I think making this portable is too much work.

marschall avatar May 28 '17 10:05 marschall