Seaside icon indicating copy to clipboard operation
Seaside copied to clipboard

WAServerAdaptor>>#handlePadding: needed anymore ?

Open Noschvie opened this issue 2 years ago • 1 comments

Hello

WAServerAdaptor>>#handlePadding:
"If you create an error page that's too small, Microsoft Internet Explorer will display its own error page that includes a link to the MSN network search engine rather than your own error page.
See http://www.404-error-page.com/404-error-page-too-short-problem-microsoft-ie.shtml for details."

^(size < 512 and: [ #(400 403 404 405 406 408 409 410 500 501 505) includes: aRequestContext response status ])
	ifTrue: [ aRequestContext response nextPutAll: ((String new: 512 - size) atAllPut: $ ) ]

is this padding needed anymore ? Thanks, Norbert

Noschvie avatar Dec 18 '23 15:12 Noschvie

I just checked and Edge still shows its own error page without padding.

However, we are no longer padding the response. I don't remember exactly why we made this change, but the comment we added reads "not desirable for REST API's and AJAX".

Cheers, Adriaan.

adriaon avatar Dec 20 '23 13:12 adriaon