Seaside icon indicating copy to clipboard operation
Seaside copied to clipboard

Add ETag support for file library

Open marschall opened this issue 3 years ago • 2 comments

Fixes #1324

marschall avatar Aug 20 '22 17:08 marschall

Requires https://github.com/SeasideSt/Grease/pull/140

marschall avatar Aug 20 '22 17:08 marschall

The annoying situation here is that GemStone uses https://github.com/GsDevKit/Grease instead of the SeasideSt/Grease... which is why the tests are still failing (at least). Will do the PR to GsDevKit to ping Dale.

jbrichau avatar Aug 26 '22 13:08 jbrichau

Any update on this?

astares avatar Jun 30 '23 10:06 astares

Any update on this?

I will take a look why the tests are failing for GemStone

jbrichau avatar Jul 01 '23 07:07 jbrichau

Codecov Report

Patch coverage: 89.58% and project coverage change: +0.01% :tada:

Comparison is base (c152487) 54.44% compared to head (95d0f2e) 54.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1325      +/-   ##
==========================================
+ Coverage   54.44%   54.46%   +0.01%     
==========================================
  Files        8833     8837       +4     
  Lines       71719    71759      +40     
==========================================
+ Hits        39045    39080      +35     
- Misses      32674    32679       +5     
Files Changed Coverage Δ
...e.package/WAResponse.class/instance/notModified.st 0.00% <0.00%> (ø)
...bstractFileLibrary.class/instance/entityTagFor..st 100.00% <100.00%> (ø)
...re.package/WAFileLibrary.class/instance/handle..st 100.00% <100.00%> (ø)
...ge/WAFileMetadataLibrary.class/instance/handle..st 100.00% <100.00%> (ø)
...re.package/WARequest.class/instance/ifNoneMatch.st 100.00% <100.00%> (ø)
...re.package/WAResponse.class/instance/entityTag..st 100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 01 '23 09:09 codecov[bot]