Sean T Allen

The release notes appear to be for a different change. For a test, please add a unit test to builtin_tests not a runner test.

A test that calling copy_to with an uninitialized array leaves the destination array unchanged is a sufficient test.

@stefandd have you read the how to contribute doc? It has good pointer like "use a different branch for each PR" I'd suggest that you should at some point, start...

> > A test that calling copy_to with an uninitialized array leaves the destination array unchanged is a sufficient test. > > > > So If I add such a...

It doesn't matter if it segfaults. It matters that it does the right thing for a given test case. That it segfaults currently isn't of much interest. It matters that...

Small nit. This isn't a bug with empty arrays. It's with uninitialized ones. If you initialized an array but let it empty, it wouldn't have segfaulted.

This still has the extra release notes from a previous PR.

After this PR is merged, @stefandd, you are going to want to delete your fork and start over because the changes you'll need to make to remove the old release...

I made a number of suggestions that should address most issues. I also added an additional test for "empty" which wasn't covered. What was covered was "uninitialized" which is slightly...

@stefandd FYI, I've found other bugs in copy_to but I want to address them in other PRs.