Sean Reece

Results 28 comments of Sean Reece

Hi @epoberezkin. Thanks for the response. My example here was purposefully simple just to get the point across but our implementation is quite complex, so doing something with an array...

> they will go out of scope leaving old pools unreachable and GC-able. @nbbeeken You're a genius ๐Ÿ˜„ Don't know why this never occurred to me. Wow, I feel like...

Closing in favour of https://github.com/mongodb/js-bson/pull/707 Thanks again for all your help @nbbeeken @H4ad. Looking forward to your input on the buffer pool

> I know people love bigger version numbers I have to admit I'm guilty of this far too often. I wouldn't normally have brought it up but they're touting this...

Thanks for all the details here. I really appreciate it. Ran a quick test [lzbench](https://github.com/inikep/lzbench) with 1.9.4 vs r129 (~9 years old). r129 is when they introduced the "new" api...

Hereโ€™s a few reasons why I donโ€™t think multiple queues really solves this problem - adding more queues means more workers. In this example, if we had 3 queues and...

@manast Thanks for the ideas. The way we're using groups is to be "fair" about processing the jobs for each tenant/customer. For example, if companyA comes in and loads in...

@nbbeeken I've made some more updates with your suggestions. - Removed Symbol properties. Now we just have private properties `pool` and `offset` - Add `getPool()` and `incrementPool()` functions. - Add...

@nbbeeken Thanks for bearing with me on this marathon ๐Ÿ˜„ As always, I appreciate the thorough reviews. Hope we're looking good now ๐Ÿš€

@nbbeeken Thanks for the heads up! Just an FYI I noticed a significant hit to memory usage and performance when I tried using private (`#`) properties for pool/offset. It looks...