Sean DuBois
Sean DuBois
That's an amazing find! Nice work :) After work I will respond. Just need to fix those issues first :(
Instead of a regex [this](https://github.com/pion/webrtc/blob/233526d67171e6efe4b65683e3c302d2e7bb5116/sdp.go#L704) should just explicitly check for `audio`, `video` or `data`. I will open a PR for that @philn !
Hey @philn Sorry I was wrong. This SDP is Plan-B (I believe?) The multiple `a=ssrc` lines in the video media section would cause it be parsed as Plan-B. The all...
Should I make `examples/esp32-whip` or add WHIP options to `examples/esp32`? I think adding WHIP to `examples/esp32` is better. I want to implement it however you think is best though!
To fix them quickly I did ``` diff --git a/examples/esp32/main/CMakeLists.txt b/examples/esp32/main/CMakeLists.txt index 424fc44..b622c63 100644 --- a/examples/esp32/main/CMakeLists.txt +++ b/examples/esp32/main/CMakeLists.txt @@ -4,3 +4,9 @@ idf_component_register(SRCS ) target_compile_options(${COMPONENT_LIB} PRIVATE "-Wno-format") + +idf_component_get_property(lib sepfy__srtp...
@jmelancongen Is this Pion on both sides when you see this happen? I would like to create a reproduce (I can help with that!) Thank you so much for sending...
Fantastic! I can write a test for that today, that will be pretty easy to reproduce.
I am so sorry @jmelancongen I lost track on this one. Thank you @JoeTurki you are amazing! So appreciative of you getting into this stuff :) I will merge this...
This could be a great optimization! All for adding this @nils-ohlmeier @om26er To keep things simple we could treate ICECandidatePoolSize as a bool. If `!= 0` then gather before signaling....