Sean DuBois

Results 605 comments of Sean DuBois

@notr1ch I don't believe that is true anymore https://github.com/cisco/openh264/releases/tag/v2.0.0 Not all features of High are supported, but I haven't had any issue with main in a few years.

@tytan652 Forcing transcodes isn't best for user. I would like to to be useful for users who are self hosting/don't have the money to pay for transcodes.

@RytoEX Agree it isn't a regression! I disagree that it is not a bug. Users are surprised/not happy with the default behavior. What *really* should happen is OBS should respect...

What qualifies something as a bug in OBS? Why do we not consider producing/sending invalid H264 for a remote not a bug? I am not trying to be pedantic, but...

Thanks for the report @introspection3! Unfortunately there is nothing we can do about STUN servers not implementing all Attributes.

The final issue was fixed with https://github.com/pion/webrtc/pull/3021 (correct me if I'm wrong @aler9! If you define codecs with explicit values (ClockRate etc...) the matching will be explicit now. The fallback...

Amazing work @shlompy! Mind fixing the failures above ^ To solve the 'Not having a SSRC' issue I was thinking maybe we add `OnRTCP` to the `webrtc.PeerConnection` ?

Hey @shlompy sorry this didn't get merged sooner! I am gonna merge it now. Next lets add a `OnRTCP` to the `PeerConnection` to get packets without a Media SSRC. I...

@shlompy Would it be ok if it didn't pass through the interceptor? Or maybe we have an interceptor that gets called for `packets without a SSRC`. I don't have a...

Nice. So my gut is Add `ReadRTCP` to PeerConnection Give you a custom Unmarshal via SettingEngine?