Sean DuBois

Results 605 comments of Sean DuBois

Hi @http600 If you remove the lastReceived/LastSent checks [https://github.com/pion/ice/blob/master/agent.go#L701-L702](here) does it reconnect? Do you always get disconnected? What causes the disconnection? I believe things are correct today. If you are...

Is it safe to modify `d.id` without holding the lock? Maybe we could make the id a `atomic.Value`? Then we drop the `unlock` and `lock`

Hi @lamhai1401 Is PionB the instance printing the message? Can you reproduce this reliably? I have been trying to reproduce/fix this and haven’t been able too!

Great graph @lamhai1401 ! So sometimes when `P1` renegotiates and adds another track `PionB` starts printing that error? Does `P1` ever remote tracks, or just add?

Hey @lamhai1401 Would you mind running https://github.com/pion/webrtc/commit/7cd8151261ec5bbb8e1b243ca94073cbc2754e69 and reproducing the issue? I am going to work on adding some tests to get to the bottom of this. @boks1971 also hit...

@lamhai1401 That line can happen if `PionA` sends before `PionB` has called `SetRemoteDescription` so it doesn't necessarily mean an error happened. * Was video not working when these were printed?...

Hi @lamhai1401 Would you mind trying v3.1.19 ? Commits 65b51732e202203cb438af6f678c510fb27c4c05 and 2949e539b7b1d483dcb3c71abe68f49f5eeef7f8 both improve Simulcast. I am not sure if it will fix your issue (since we don't have a...

Nice catch! Thanks for reporting @atoppi I don't think we take direction into account at all when parsing extensions. I will fix that :)

@mohammadne fantastic work! I would love to add these. Could you also put the image in the README themselves? A few changes * Instead of `Callee` and `Caller` can you...