Sean DuBois
Sean DuBois
The extra memory usage will be the 5 seconds of video. It shouldn't impact bandwidth, the NACKs are only requested on loss. I don't have a strong opinion either. I...
@tt2468 Yep as you described, available but not always filled. It would be really nice to bump this especially for users with higher bitrates and packet loss, the current value...
Hey @ekcheng thanks for checking out KVS! Since you are working with OpenCV you can probably leverage others libraries for MKV parsing. You just need to call GetMedia to pull...
@paullouisageneau I have updated this PR with your suggested API ``` config.disableAutoGathering = true; .... ... std::vector iceServers = {}; iceServers.emplace_back("localhost", 3478, "foo", "bar"); peer_connection->gatherLocalCandidates(iceServers); ```
@paullouisageneau can I get another review please, thank you!
Ok last one I hope @paullouisageneau I think I got it this time :)
@paullouisageneau whats left for a new tag? I can take on the tasks!
@maxhawkins This is an interesting one! Going back through old tickets and I want to build this! This would be amazing for people to learn and debug. I don't think...
@kevmo314 Would love to make it easier for you! I am all for providing better APIs. It will require a fair amount of work to design them, but I am...
@sipsorcery @shinyoshiaki @steely-glint @jlaine what do you think? Some of these come from bugs/mistakes in Pion that really hurt, and I don't want to see others have to deal with.