Sean DuBois

Results 605 comments of Sean DuBois

Hey @Generalomosco it would be really amazing if you were able to share this with others! If you are able to open a PR to this repo me and @at-wat...

If you apply https://github.com/pion/mdns/pull/70 does it work? Most of my attention is on https://github.com/pion/webrtc, but will try my best to get this working!

@cgojin sorry I have been slow on reviews :( I think this is a great change, are you still interested in merging it?

Hey @rybakit! Good news first! Using msgpack at `105961a93599a5a12f2e33eaebe7b25ac69f1984` `var_dump(bin2hex(msgpack_unpack("\xc4\x01\x80")));` gives me `string(2) "80"` Bad news is that we are just packing your data as string/raw [this](https://github.com/msgpack/msgpack-php/blob/master/msgpack/pack_template.h#L732). Even though this...

@rybakit Right now we don't look at the string we are packing, so "\x80" is just handled like every other string. I will look at the Python library and see...

I really appreciate you making msgpack-php better _just because_! Sure needs some people who care about quality.. as I mess things up! Let me look at what I can do...

Hi @zhangbiao2009 ! Let me check the other msgpack implementations, this _may_ be out of scope. I get this is really useful, but you can just walk the returned structure...

@daonb we don't control those, I don't know if we can add stuff. Here are all the [values](https://www.w3.org/TR/webrtc/#dictionary-rtcdatachannelinit-members). Since we also compile to WASM mode it will cause portability issues....

@daonb you can skip right to the PR even (and link to this issue in the commit). I am happy to merge this right away so you can get back...

@wawesomeNOGUI I invited you to the GitHub org, those tests should run now! Method names look great to me. I would prefer to not use `unsafe` it sometimes causes portability...