Sean DuBois

Results 605 comments of Sean DuBois

I wrote this benchmark, but didn't commit it ``` func Benchmark_TrackLocalStaticRTP_SendOnly_WriteRTP(b *testing.B) { offer, answer, err := newPair() assert.NoError(b, err) track, err := NewTrackLocalStaticRTP(RTPCodecCapability{MimeType: "video/vp8"}, "video", "pion") assert.NoError(b, err) _,...

@at-wat sorry missed that! I am 100% in support of leaving it as a pointer, agree with your points. `/v3` needs to go out and I don't think changing it...

@scorpionknifes that is a very good point. Maybe we just test the current commit against `master`? We can always make it optional, even if we get some false positives I...

I spent some time doing research today and found https://pythonspeed.com/articles/consistent-benchmarking-in-ci/ cachegrind looks promising! This might be a 'master only' thing depending on how much longer this makes the tests run.

Hey @Demuzx Is it still incorrect after calling `Close` on the file like here https://github.com/pion/webrtc/blob/master/examples/save-to-disk/main.go#L115 ? We also have this PR, but I haven't had time to work on it...

Sorry I can't be more help guys :( I need to get TURN + DTL-PSK done. Right after I can dig in though! If you want to jump on [Slack](https://pion.ly/slack)...

@maxhawkins This all landed right? It would be cool to have an example for this, currently we don't have a way to do easy 'playback'. I think this could be...

This might be a useless interjection, but I have a JSON output started with https://github.com/Sean-Der/fail2rest If you plan on implementing JSON output in fail2ban I would love for it to...

@schorsch thanks! Because of all the libs it would be pretty hard to get into one file. Most of the time I just build a binary and scp it around...

In good news with this merged I am able to use json :) ``` package main import ( "encoding/json" "fmt" ) type JSONStruct struct { Outer string Embedded struct {...