Seagate
release tarballs aren't buildable
The release tarballs don't include the git submodules, which makes them unbuildable. Tested on OpenSeaChest 18.04 with the release tarball posted on GitHub.
We are working on a 18.10 release which will be finished before the end of this month and it should have all the FreeBSD fixes.
The problem with the release tarballs isn't FreeBSD-specific; they simply don't include all of the code. The tarballs, as opposed to the git checkout, don't build anywhere.
I added a new action that will create a Source_With_Submodules.tar.xz and Source_With_Submodules.zip when we push release tags.
It seems that the default for a release uses git archive which does not traverse submodules. I read up on this issue (multiple git repos on Github have similar issues filed) and it seems git-archive-all is the best solution to use, so this new Github action will use that to publish these at the releases going forward.
I see the new tarball in the alpha release https://github.com/Seagate/openSeaChest/releases/tag/v23.02-alpha.1, and it looks to build just fine for me. I think it is a little weird that the folder extracts to Source_With_Submodules. and I'd maybe prefer it extract to openSeaChest-23.02-alpha.1 to match the release version. But that's just stylistic, it doesn't really matter. Thanks for adding this, it'll save me a lot of trouble!
@faithanalog I will investigate changing that to the version you mentioned. I think that would make a lot more sense.
This has been fixed in https://github.com/Seagate/openSeaChest/releases/tag/v23.03 I even got the subfolder to have a nice name like @faithanalog mentioned previously! 😄
If you have any trouble, please feel free to reopen this issue and I will look at this again.