cortx-s3server icon indicating copy to clipboard operation
cortx-s3server copied to clipboard

Change dependencies scope to test for test libraries

Open kiwionly2 opened this issue 3 years ago • 9 comments

This make sure test dependencies not included in build artifact and also make the build artifact size smaller.

Signed-off-by: kiwi [email protected]

Problem Statement

  • Problem statement

Design

  • For Bug, Describe the fix here.
  • For Feature, Post the link for design

Coding

Checklist for Author

  • [ ] Coding conventions are followed and code is consistent

Testing

Checklist for Author

  • [ ] Unit and System Tests are added
  • [ ] Test Cases cover Happy Path, Non-Happy Path and Scalability
  • [ ] Testing was performed with RPM

Impact Analysis

Checklist for Author/Reviewer/GateKeeper

  • [ ] Interface change (if any) are documented
  • [ ] Side effects on other features (deployment/upgrade)
  • [ ] Dependencies on other component(s)

Review Checklist

Checklist for Author

  • [ ] JIRA number/GitHub Issue added to PR
  • [ ] PR is self reviewed
  • [ ] Jira and state/status is updated and JIRA is updated with PR link
  • [ ] Check if the description is clear and explained

Documentation

Checklist for Author

  • [ ] Changes done to WIKI / Confluence page / Quick Start Guide

kiwionly2 avatar Oct 28 '21 04:10 kiwionly2

Can one of the admins verify this patch?

cortx-admin avatar Oct 28 '21 04:10 cortx-admin

Pre-Merge: http://eos-jenkins.colo.seagate.com/job/S3server/job/S3Server-PreMerge-Test/503/

VM Deployment: http://eos-jenkins.colo.seagate.com/job/Cortx-PR-Build/job/Cortx-Deployment/job/CentOS-7.9.2009/job/s3server/

Mini-Provisioning: http://eos-jenkins.colo.seagate.com/job/Cortx-PR-Build/job/Mini-Provisioning/job/CentOS-7.9.2009/job/S3-Server/583/

SaumitraK531 avatar Nov 01 '21 04:11 SaumitraK531

#503 failed

nileshgovande avatar Nov 01 '21 12:11 nileshgovande

@shalakadharap Pls help @kiwionly2

@kiwionly2 maybe you can rebase the branch with latest main and can run quick start guide steps on this PR branch

nileshgovande avatar Nov 02 '21 04:11 nileshgovande

@nileshgovande

I had rebase the branch, let me know if need any steps to proceed ?

kiwionly2 avatar Nov 02 '21 05:11 kiwionly2

This issue/pull request has been marked as needs attention as it has been left pending without new activity for 4 days. Tagging @nileshgovande @bkirunge7 @knrajnambiar76 @t7ko-seagate for appropriate assignment. Sorry for the delay & Thank you for contributing to CORTX. We will get back to you as soon as possible.

stale[bot] avatar Nov 06 '21 08:11 stale[bot]

@kiwionly2 Please rebase again, run Quick Start Guide on your branch and confirm

nileshgovande avatar Nov 15 '21 05:11 nileshgovande

@nileshgovande

Rebase done.

kiwionly2 avatar Nov 16 '21 11:11 kiwionly2

This issue/pull request has been marked as needs attention as it has been left pending without new activity for 4 days. Tagging @nileshgovande @bkirunge7 @knrajnambiar76 @t7ko-seagate for appropriate assignment. Sorry for the delay & Thank you for contributing to CORTX. We will get back to you as soon as possible.

stale[bot] avatar Nov 20 '21 12:11 stale[bot]