seaography icon indicating copy to clipboard operation
seaography copied to clipboard

Update to Rust Edition 2024

Open billy1624 opened this issue 8 months ago • 1 comments

Breaking Changes

  • [x] Update to Rust Edition 2024
  • [x] Update Minimum Supported Rust Version (MSRV) to Rust 1.85.0

billy1624 avatar May 17 '25 08:05 billy1624

we should delay this after the 1.x branch is feature frozen right now we're still continuously rebasing master onto 1.x

tyt2y3 avatar Aug 20 '25 12:08 tyt2y3

I suggest also updating the macro crate to the 2024 edition and minimum rust version 1.88 (rust issue

error[E0658]: `let` expressions in this position are unstable
  --> macros/src/custom_fields.rs:85:8
   |
85 |     if let Some(arg) = args.get(argno)
   |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information

error[E0658]: `let` expressions in this position are unstable
   --> macros/src/custom_fields.rs:171:8
    |
171 |     if let FnArg::Typed(pat) = arg
    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information

error[E0658]: `let` expressions in this position are unstable
   --> macros/src/custom_fields.rs:172:12
    |
172 |         && let Type::Reference(TypeReference { elem, .. }) = &*pat.ty
    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information

error[E0658]: `let` expressions in this position are unstable
   --> macros/src/custom_fields.rs:173:12
    |
173 |         && let Type::Path(path) = elem.as_ref()
    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information

error[E0658]: `let` expressions in this position are unstable
   --> macros/src/custom_fields.rs:174:12
    |
174 |         && let Some(last_segment) = path.path.segments.last()
    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information

error[E0658]: `let` expressions in this position are unstable
  --> macros/src/util.rs:32:45
   |
32 |                 let inner_name: String = if let Some(first) = unnamed.unnamed.first()
   |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information

error[E0658]: `let` expressions in this position are unstable
  --> macros/src/util.rs:33:24
   |
33 |                     && let Type::Path(path) = &first.ty
   |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information

error[E0658]: `let` expressions in this position are unstable
  --> macros/src/util.rs:35:24
   |
35 |                     && let Some(seg) = path.path.segments.first()
   |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information

For more information about this error, try `rustc --explain E0658`.
error: could not compile `seaography-macros` (lib) due to 8 previous errors

SindriFr avatar Nov 13 '25 11:11 SindriFr