Enable clippy::pedantic
PR Info
Enable clippy::pedantic
Still missing # Errors and # Panics docs.
I'm not sure whether I should add panic docs or remove panics.
Please take a look, @Expurple @tyt2y3.
I think adding some panic docs is easiest right now. Converting panic to Error is not possible, unless ... we convert the API to return Result in build() etc, which is another big breaking change.
I honesty think we're running out of "innovation token" to make this change, but may be not!
Another thought is instead of panicking, we return some syntatically incorrect SQL, it will end up as an error.
I honesty think we're running out of "innovation token" to make this change
I agree. It feels like we should be wrapping up this SeaQuery release soon and moving on to SeaORM-specific tasks.
Another thought is instead of panicking, we return some syntatically incorrect SQL, it will end up as an error.
Sounds weird. I'd keep the panics for now and figure it out later
This is ready to be merged.
What about the semicolon check in CI? Looks good otherwise