sea-query icon indicating copy to clipboard operation
sea-query copied to clipboard

Publically export FuncArgMod

Open mgmarlow opened this issue 1 year ago • 0 comments

PR Info

Just like #get_args and #get_func, make a getter for mods, #get_mods, and make FuncArgMod public.

We're using sea-query with a non-supported database (Hive). The QueryBuilder interface set up in sea-query is nicely designed such that we can extend it for our purposes, but it has a problem in that many of the internals used by similar QueryBuilder structs (e.g. sqlite, postgres) make use of private APIs. This means that while the path is clear for creating a custom query builder, doing so without maintaining a fork requires duplicating lots of code to create public interfaces for our project.

#get_mods is one such interface that we need to write DISTINCT queries in our query builder.

New Features

  • Add FunctionCall#get_mods to get FuncArgMods

Bug Fixes

NA

Breaking Changes

NA

Changes

  • Publically export FuncArgMod struct
  • Add FunctionCall#get_mods

mgmarlow avatar Feb 06 '24 17:02 mgmarlow