sea-query icon indicating copy to clipboard operation
sea-query copied to clipboard

support partial index

Open kyoto7250 opened this issue 3 years ago • 16 comments

PR Info

close #396 We supports partial index by this PR.

Adds

  • [x] support partial index.
    • [x] resolve conflict
    • [x] check comment

Related

https://github.com/SeaQL/sea-query/pull/405 (original PR)

kyoto7250 avatar Oct 16 '22 11:10 kyoto7250

@kyoto7250 is this PR ready?)

ikrivosheev avatar Oct 17 '22 14:10 ikrivosheev

@ikrivosheev Thank you for your quick reply :)

I want to confirm that this PR works as expected in the database at hand (not yet confirmed, so this PR is a WIP).

kyoto7250 avatar Oct 18 '22 04:10 kyoto7250

@kyoto7250 any updates?)

ikrivosheev avatar Nov 13 '22 21:11 ikrivosheev

Hey @kyoto7250, I highly recommend this site for testing SQL syntax across various databases :)

@billy1624 which site do you mean?

ikrivosheev avatar Dec 17 '22 10:12 ikrivosheev

@ikrivosheev Good question!! I forgot to post the link loll

billy1624 avatar Dec 19 '22 07:12 billy1624

@kyoto7250 hello, any updates?)

ikrivosheev avatar Mar 19 '23 18:03 ikrivosheev

We would love to see this feature land, too! :)

wolfv avatar Apr 04 '23 10:04 wolfv

Ah...sorry, I completely forgot about this PR... It seemed like the notifications were turned off in my account. Is this still an alive PR?

I need to catch up on this library updates, so if you hurried up, you can close this pr.

kyoto7250 avatar Oct 10 '23 10:10 kyoto7250

Glad that you are back! Apart from the conflicts, I think we can still merge this PR.

tyt2y3 avatar Oct 12 '23 08:10 tyt2y3

Hey @kyoto7250 @tyt2y3 any updates on this? I could really use this feature.

IgnisDa avatar Oct 27 '23 09:10 IgnisDa

I made the PR for fixing failed CI.

https://github.com/SeaQL/sea-query/pull/718

kyoto7250 avatar Nov 02 '23 14:11 kyoto7250

@kyoto7250 I believe this should be ready to be merged?

IgnisDa avatar Jun 19 '24 13:06 IgnisDa

Okay, I will check in this week. Thank you for calling me.

kyoto7250 avatar Jun 19 '24 14:06 kyoto7250

After rebasing, I increased the version of bigdecimals so that the build would succeed.

kyoto7250 avatar Jun 24 '24 13:06 kyoto7250

This PR is now available for review.

kyoto7250 avatar Jul 01 '24 13:07 kyoto7250

@billy1624 @ikrivosheev Sorry for the long delay in correcting the PR. Could you give me your review?

kyoto7250 avatar Jul 14 '24 03:07 kyoto7250