get time from sqlx-sqlite directly

[kyoto7250]

PR Info

• Closes close #409

Changes

• [x] get time from sqlx-sqlite directly

Breaking Changes

• [x] In DateType, time is no longer compatible with chrono .

[ikrivosheev]

@kyoto7250 some tests failed

[kyoto7250]

Ah, This code does not work because It is not pattern matching anymore. I didn't notice because the test passes.

v @ Value::TimeDate(_) => query.bind(v.as_deref())

Thank you, I fixed in https://github.com/SeaQL/sea-query/pull/412/commits/a8806ed1c5eff57ebdb4f248e179294626c671d9.

[kyoto7250]

@ikrivosheev

Hmm, we got a runtime error in CI.

Sorry, I will check it.

[ikrivosheev]

@ikrivosheev

Hmm, we got a runtime error in CI.

Sorry, I will check it.

I think sqlx convert time object differently than sea-query do it before...

[kyoto7250]

It appears that sqlx v0.6.1 returns subsecond in DateTime, but this behaviour is different from chrono. I think this PR includes breaking change.

https://github.com/SeaQL/sea-query/blob/6db27fdc82285a9e585997a762438b5c941b0073/src/value.rs#L436-L437

[kyoto7250]

Sorry, I am traveling until this week, so I will check it in this weekend.

Thank you for your kind 👍🏽

[kyoto7250]

I'm sorry I'm late. I resolved the conflict. And I revert 34b96fb, so could you please review again?

[ikrivosheev]

@kyoto7250 hello! Can you resolve merge conflict?

[ikrivosheev]

@kyoto7250 any updates?