sea-orm icon indicating copy to clipboard operation
sea-orm copied to clipboard
verified publisher icon SeaQL

Struct / enum derive PartialEq should also derive Eq

Open w93163red opened this issue 3 years ago • 1 comments

PR Info

  • Closes https://github.com/SeaQL/sea-orm/issues/965

Adds

[codegen] Struct / enum derive PartialEq should also derive Eq

Changes

Add a function to check if f32/f64 exists on the column. If not, add Eq on the derived part.

Testing:

  1. update the previous tests to match the new mechanism.
  2. Add two tests to if Eq is not generated when f32/f64 in the column.

w93163red avatar Aug 24 '22 19:08 w93163red

I merged the change~ Thanks!

w93163red avatar Aug 25 '22 14:08 w93163red

Awesome

tyt2y3 avatar Sep 26 '22 16:09 tyt2y3

It would be very useful to have this as soon as possible.

Every time we generate with 0.9.3 we have to undo the changes (I cannot disable linting in CI).

Can we release 0.9.4 with this only?

frederikhors avatar Oct 12 '22 14:10 frederikhors

Can do

tyt2y3 avatar Oct 12 '22 14:10 tyt2y3

Can do

? Are you going to?

frederikhors avatar Oct 14 '22 09:10 frederikhors