sea-orm icon indicating copy to clipboard operation
sea-orm copied to clipboard

Published 20 hours ago • verified publisher icon SeaQL

Upgrade SeaQuery at SeaORM root to v0.27

Open billy1624 opened this issue 3 years ago • 2 comments

PR Info

  • Closes https://github.com/SeaQL/sea-orm/issues/969
  • Dependents:
    • https://github.com/SeaQL/sea-orm/pull/986

Breaking Changes

  • [x] Upgrade SeaORM root's SeaQuery to v0.27

billy1624 avatar Aug 24 '22 07:08 billy1624

@billy1624, hello! I think we can combine your PR and mine PR: https://github.com/SeaQL/sea-orm/pull/970

ikrivosheev avatar Sep 07 '22 15:09 ikrivosheev

Agree!

billy1624 avatar Sep 08 '22 04:09 billy1624

@billy1624 hello! Why didn't we use ColumnDef and ColumnType from sea-query?

ikrivosheev avatar Sep 22 '22 17:09 ikrivosheev

This is a good question. The primary motivation is SeaQuery integer types have the optional (and meaningless and deprecated) column width parameter , i.e. integer(8). And I wanted to hide these from the SeaORM API. So the right thing to do might be to remove those from SeaQuery.

The ethos is, SeaORM is higher-level and so should provide some reasonable defaults.

tyt2y3 avatar Sep 27 '22 15:09 tyt2y3

Definitely add some test cases for sqlx-postgres-array!

tyt2y3 avatar Oct 17 '22 13:10 tyt2y3

Definitely add some test cases for sqlx-postgres-array!

I will add that in a separate PR. Let's focus on bumping SeaQuery version on this PR.

billy1624 avatar Oct 18 '22 10:10 billy1624

Hey @tyt2y3, ready for review as well.

billy1624 avatar Oct 18 '22 12:10 billy1624

Strange, there are still failure https://github.com/SeaQL/sea-orm/actions/runs/3275174232/jobs/5389786280

tyt2y3 avatar Oct 18 '22 16:10 tyt2y3

We need to publish a new version for sea-query-binder as well. Since we also changed the binder.

billy1624 avatar Oct 19 '22 03:10 billy1624

I noticed that if you use the ipnetwork or the mac_address feature in sea-query-binder, you get an error in sea-Tom, because they are not supported. Is this a known issue?

Razican avatar Oct 19 '22 11:10 Razican