sea-orm
sea-orm copied to clipboard
[ADD]: Pre-commit hook to keep the project clean
Summary
One can run a script to verify whether their changes are working, do they pass the automated tests etc?
Motivation
Integration tests
Additional Information
Hey @AbhijithGanesh, we do have GitHub Actions for running unit tests and integration tests. https://github.com/SeaQL/sea-orm/actions
@billy1624 I meant, local pre-commit hooks for a smoother dev flow
Apologies, closed by mistake.
Apologies, closed by mistake.
Hahaa nvm!
I wonder what will be checked inside the pre-commit hooks? For example, running cargo fmt
?
Unfortunately I have not seen #611 before amking this. I think there is a slight conflict now, i will touch on this under the actual PR.
Hey @AbhijithGanesh, sorry for the conflict. I think similar code has been merged
- https://github.com/SeaQL/sea-orm/pull/840
- https://github.com/SeaQL/sea-orm/pull/919
Please check if you have anything to add.
Thanks @billy1624
Hey @AbhijithGanesh, please close this issue and PR (https://github.com/SeaQL/sea-orm/pull/611) if you think the merged PR is good enough and you have nothing to add.
Once again, thank you so much for the contributions :)
I think this PR is still open which can be merged. It's a pre commit check script which I think was good for developers to run locally.