sea-orm icon indicating copy to clipboard operation
sea-orm copied to clipboard

Implement "Nest" for `DerivePartialModel` and From `QueryResult`

Open Goodjooy opened this issue 1 year ago • 4 comments

PR Info

  • #1715

New Features

  • [x] FromQueryResult support flatten
  • [x] DerivePartialModel support flatten
  • [x] document update
  • [x] test case

Changes

  • [x] FromQueryResult has attributes sea_orm

Goodjooy avatar Jun 21 '23 13:06 Goodjooy

Thank you for the contribution again! You might be a stronger derive macro guru than I am. Hopefully this will not conflict with the effort "upgrade to syn2" #1713

tyt2y3 avatar Jun 22 '23 07:06 tyt2y3

Thank you for the contribution again! You might be a stronger derive macro guru than I am. Hopefully this will not conflict with the effort "upgrade to syn2" #1713

Crate syn with its major version update usually contain one or more break changes ,I cannot guarantee there is no conflict.

I think I can wait for that PR merged ,then I will handle the conflict in this PR.

Goodjooy avatar Jun 22 '23 12:06 Goodjooy

Two things:

  1. the implementation looks nice!
  2. can you add an example or test case showing how the flatten should work?
  3. what do those icon in front of the commit messages mean? is there a translation table? 👀

tyt2y3 avatar Sep 09 '23 11:09 tyt2y3

Two things:

1. the implementation looks nice!

2. can you add an example or test case showing how the flatten should work?

3. what do those icon in front of the commit messages mean? is there a translation table? 👀

2 things but 3 points :)

The emoji is 'gitmoji' I like using those emoji to mark each commit action. this is the webside of https://gitmoji.dev/

I'll add examples in the near future.

Goodjooy avatar Sep 09 '23 14:09 Goodjooy

(Sorry for coming in from the side..)

Is there a specific reason this was closed? We were looking forward to using this - if required, I can also take a shot at implementing the nesting bit.

jreppnow avatar Mar 18 '24 08:03 jreppnow

(Sorry for coming in from the side..)

Is there a specific reason this was closed? We were looking forward to using this - if required, I can also take a shot at implementing the nesting bit.

Why this pr closed? I had never close it?

Goodjooy avatar Mar 19 '24 16:03 Goodjooy

However, the code is a bit old, I need time to read and refactor it

Goodjooy avatar Mar 19 '24 16:03 Goodjooy

@Goodjooy Hi again、I am really sorry for coming in from the side, but since we kind of desperately need this feature, I decided to do a separate implementation in #2179 . I honestly only care about this feature landing as quickly as possible, so I would not mind if you take my code and update your PR, if you prefer that path instead of my PR superseding yours.

CC: @tyt2y3

jreppnow avatar Mar 29 '24 11:03 jreppnow

@Goodjooy Hi again、I am really sorry for coming in from the side, but since we kind of desperately need this feature, I decided to do a separate implementation in #2179 . I honestly only care about this feature landing as quickly as possible, so I would not mind if you take my code and update your PR, if you prefer that path instead of my PR superseding yours.

CC: @tyt2y3

Maintaining your own modified version of the nest feature might be a more ideal way right now. Adding features usually needs a minor version update which might waiting a bit longer than bug fixing. Not to mention that the core maintainers now are busy in releasing the 1.0 version right now.

Goodjooy avatar Mar 29 '24 16:03 Goodjooy

Hey, thank you for everyone's involvement. I think the only things missing from this PR are some tests and a bit of doc example?

tyt2y3 avatar Mar 29 '24 17:03 tyt2y3

there was a better one #2179 that this pr can be close

Goodjooy avatar Apr 01 '24 10:04 Goodjooy