seagl.github.io icon indicating copy to clipboard operation
seagl.github.io copied to clipboard

TravisCI test to make sure site builds without errors

Open edunham opened this issue 9 years ago • 4 comments

It'd be great to add a test so we know if PRs will break the web site's build.

edunham avatar Aug 03 '16 20:08 edunham

Sounds like this is built in to GitHub now:

When you create a pull request to update your publishing source on GitHub, you can see build error messages on the Checks tab of the pull request.

AndrewKvalheim avatar Aug 24 '20 00:08 AndrewKvalheim

@AndrewKvalheim I think you might be confused about the role that Travis plays and what these Status Checks are. The Status Checks are just indicators. You still need to implement the tests that determine whether the Status Check shows success/failure. This can be done using Travis, but my personal vote would be to use GitHub's newer Actions (https://github.com/features/actions) which avoid us having to setup a new service.

Regardless of whether we use Travis or GitHub Actions, we still need to setup a configuration file that specifies the "test" to run. In our case, the test is attempting to build the website.

nhandler avatar Aug 24 '20 00:08 nhandler

Thanks. I took the above to imply that the existing GitHub Pages build service must include pull requests, otherwise the documentation would be misleading.

AndrewKvalheim avatar Aug 24 '20 03:08 AndrewKvalheim

If there are no plans to merge a pull request that implements the functionality as specified in the top comment, then perhaps this issue should be closed or respecified. If GitHub Actions really is the desired path forward, then this should be clarified.

garrison avatar Oct 10 '21 02:10 garrison