Add tokio feature

[SofusA]

Thanks for this! I am building a tui and web player player for qobuz, and this has helped a lot!

I am using tokio for async, so i need to enable tokio feature for zbus. This just adds a feature which enables this

[SeaDve]

Hi, thanks for the PR!

It would be nice to also get this added on the README, on the features table.

I think it would also be needed to fix CI to prevent async-std and tokio features from interfering with each other.

[SofusA]

I have resolved the clippy warnings in #11. We should wait for that first

[SofusA]

I think it would also be needed to fix CI to prevent async-std and tokio features from interfering with each other.

It looks like CI is fine. Is there something particular that you think needs to be done? :smiley:

[SeaDve]

Ah, I thought it would since --all-features should conflict tokio and async-std

[SeaDve]

Also, I think it would make sense to have a compile time error when both features are active at the same time.

[SofusA]

I have added a line to the features list in the readme.

Also, I think it would make sense to have a compile time error when both features are active at the same time.

Sorry I don't think i understand what the problem is. The tokio feature is only passed on to zbus. async-std-feature is enabled by default and will be overridden with the tokio-feature by zbus

[SofusA]

Hey. Can you try to elaborate what is needed for this to be merged? 🙂

[SeaDve]

Hello! Sorry for the really late reply. I was not just so sure if this would cause some problems somewhere, since zbus has async-io feature by default, and enabling tokio feature of zbus would conflict with it unless default-features is set to false.

I thought that adding a test somewhere on the CI proving it won't be nice.

[SofusA]

Hello! Sorry for the really late reply. I was not just so sure if this would cause some problems somewhere, since zbus has async-io feature by default, and enabling tokio feature of zbus would conflict with it unless default-features is set to false.

I thought that adding a test somewhere on the CI proving it won't be nice.

No problem. I think this would be zbus's concern.

But i could add a CI step that builds with this feature. Would that be sufficient?

[SofusA]

I found some clippy errors on rebasing. I fixed them in a separate commit

[SeaDve]

But i could add a CI step that builds with this feature. Would that be sufficient?

I think yes, and one without.

I found some clippy errors on rebasing. I fixed them in a separate commit

Thanks! Sorry for the late reply, I was really busy with school stuff

[SofusA]

I have added a job to CI pipeline for building default, and with tokio feature. I also got some formatting errors. They have been fixed in a commit.

Really no problem. Take your time. I can just reference my branch in my Cargo.toml to use the feature :smile:

[SeaDve]

Thanks!