Dave Patrick

Results 420 comments of Dave Patrick

May you link the commit or the PR

I think every feature is now documented, and almost on par with Builder features, except #1.

Is this still reproducible in the latest version? As far as I know, you don't need `flatpak-spawn` unless you have VSCode as Flatpak; thus, you can simply use `flatpak build`...

I'm not sure if testing isFlatpak/isSandboxed is possible

There's also a guide in [CONTRUBUTING.md](https://github.com/bilelmoussaoui/flatpak-vscode/blob/master/CONTRIBUTING.md#integration-with-other-extensions). And for examples, see `src/integration/rustAnalyzer.ts` or `src/integration/vala.ts`.

Kooha requires libadwaita 1.2 to build, it won't work with 1.1

My bad for using unreleased software. But, at least on Flatpak, I tested it to ensure that things work as expected, so users would not notice any problem at all...

Also, I noticed from https://github.com/archlinux/svntogit-community/blob/packages/kooha/trunk/PKGBUILD, it seems to be still depending on `python-gobject`. I think that can be removed.

> Thanks. I'm trying to build against libadwaita 1.2 now and ran into this ... perhaps related perhaps not. Pinging @orhun the other Arch Linux packager on this app since...

> Why would it need to be _initialized_? One should not need to be in an active GUI environment to build an app. The libraries it needs to build against...