Kooha icon indicating copy to clipboard operation
Kooha copied to clipboard

Opaque (black) area selector on sway

Open SeaDve opened this issue 3 years ago • 6 comments

Some related:

  • [ ] There should be fade (not window) animation when closing the selector window
  • [ ] Don't show on taskbar or overview
  • [ ] Don't hide status bar

#42

SeaDve avatar Aug 09 '21 10:08 SeaDve

Ill check again of slurp, if it works now on gnome

Edit: yep it still doesnt support it: compositor doesn't support zwlr_layer_shell_v1

SeaDve avatar Aug 09 '21 10:08 SeaDve

slop seems to support both gnome and sway.

SeaDve avatar Aug 09 '21 10:08 SeaDve

I decided to check out slop. It seems a bit abandoned when looking into commit and git issue history.

Is it not viable to use slurp for wlroots based WMs like Sway? You already detect environment so if sway/wlroots get coordinates etc using slurp? If gnome, continue as you are.

asjur avatar Aug 20 '21 08:08 asjur

Splitting the code would be kinda make the code more messy. Since, the current implementation that works on gnome is also hacky, I think it would be better to implement something similar to slop, since it seems to work well on almost all environment without splitting the code

SeaDve avatar Aug 20 '21 08:08 SeaDve

Has there been any progress on this?

ProjectInfinity avatar Sep 19 '21 23:09 ProjectInfinity

I don't have much time to work on Kooha anymore as before, if anyone would like to submit a pr, it would be great

SeaDve avatar Sep 19 '21 23:09 SeaDve

Fixed on main branch with a non-hacky area selector:

https://github.com/SeaDve/Kooha/commit/b025b8ad5d6d36f6b261e8c175eb77518690ff11

image

SeaDve avatar Sep 28 '22 03:09 SeaDve