scuffle
scuffle copied to clipboard
feat(platform): offline banners
Proposed changes
This pr implements offline banners.
Including:
- New section in profile settings
- New upload endpoint for offline banners
Types of changes
What types of changes does your code introduce to Scuffle?
Put an x
in the boxes that apply
- [ ] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
Checklist
Put an x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
- [x] I have read the CONTRIBUTING doc
- [ ] Lint and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] I have added necessary documentation (if appropriate)
- [x] Any dependent changes have been merged and published in downstream modules
Further comments
Codecov Report
Attention: 306 lines
in your changes are missing coverage. Please review.
Comparison is base (
d94b57d
) 45.48% compared to head (e77c8fb
) 45.15%.
Additional details and impacted files
@@ Coverage Diff @@
## feature/website #197 +/- ##
===================================================
- Coverage 45.48% 45.15% -0.34%
===================================================
Files 489 491 +2
Lines 32133 32369 +236
===================================================
Hits 14617 14617
- Misses 17516 17752 +236
Files | Coverage Δ | |
---|---|---|
platform/api/src/database/channel.rs | 0.00% <ø> (ø) |
|
platform/api/src/database/file_type.rs | 0.00% <ø> (ø) |
|
platform/api/src/database/role.rs | 0.00% <ø> (ø) |
|
platform/api/src/api/v1/gql/mutations/user.rs | 0.00% <0.00%> (ø) |
|
platform/api/src/subscription.rs | 0.00% <0.00%> (ø) |
|
video/cli/src/invoker/direct.rs | 0.00% <0.00%> (ø) |
|
video/ingest/src/ingest/connection.rs | 75.41% <50.00%> (ø) |
|
platform/api/src/api/v1/upload/mod.rs | 0.00% <0.00%> (ø) |
|
platform/api/src/config.rs | 0.00% <0.00%> (ø) |
|
platform/api/src/video_event_handler.rs | 0.00% <0.00%> (ø) |
|
... and 8 more |