Sefa Eyeoglu
Sefa Eyeoglu
Maybe we should split this up into multiple PRs. Some things like reordering includes should be fine. Potentially we can also just cherry-pick a few of the smaller commits.
Oh my god, thanks GitHub. I was reviewing a single commit, but it doesn't link there.
We can do this once MMC adopts a CLA
Changed it, so it looks like it used to before #652 was merged
I think we should just use gcc. It is close to what most people use as well and we should try to use the standard compiler on all OSes. This...
Well good luck trying to use MSVC :sweat_smile: I just don't see any value by using Clang over GCC, if this will not affect overall build times at all, but...
> Paused until a multi-arch pr is merged, because of the dep on architecture detection You need to write your own detection. The detection in #1033 works by querying the...
Yes that sounds interesting. So maybe it should autoselect the latest version when double clicking a mod or pressing enter? Then selected mods should probably be marked as such in...
Windows Qt 6 builds = epic prank
The resolver for FTB modpacks also uses a similar dialog. Can you update that as well? https://github.com/PolyMC/PolyMC/blob/b15544c163ccbca08ea498b3b3a51c82d7fb3e12/launcher/modplatform/modpacksch/FTBPackInstallTask.cpp#L201-L215 You probably need to rebase onto develop / merge it into your branch...