scrivito_example_app_js icon indicating copy to clipboard operation
scrivito_example_app_js copied to clipboard

Published 20 hours ago • verified publisher icon Scrivito

Neoletter | Form Builder | Subscription as a hidden field

Open dawgoc opened this issue 1 year ago • 6 comments

Related to https://github.com/Scrivito/scrivito_example_app_js/pull/535

To make the subscription process more straightforward, we've made a change in the Form Builder. Previously, users had to actively check a specific checkbox to subscribe. We realized this step might not be necessary for all types of subscription forms. To simplify the process, we've incorporated the subscription action as a hidden field within the form. This means that when users fill out the form, the subscription process is initiated without the need for the user to check an additional checkbox.

Currently, subscription feature-related fields are activated when the ENABLE_NEOLETTER_FORM_BUILDER_SUBSCRIPTION_FEATURE environment variable flag is set.

Without flag: Screenshot 2023-08-21 at 14 27 35

With flag: Screenshot 2023-08-21 at 14 13 54 Screenshot 2023-08-21 at 14 13 59 Screenshot 2023-08-21 at 14 14 10

dawgoc avatar Aug 21 '23 12:08 dawgoc

Deploy request for scrivito-example pending review.

Visit the deploys page to approve it

Name Link
Latest commit 5692255870fdd206e3880d62da226a3b8de2ae6a

netlify[bot] avatar Aug 21 '23 12:08 netlify[bot]

FYI: I will not be able to review this PR in the near future. My queue is quite full with high priority tasks.

apepper avatar Aug 31 '23 12:08 apepper

FYI: I will not be able to review this PR in the near future. My queue is quite full with high priority tasks.

Would be cool, if we could get this merged 😎

jfienhold avatar Oct 21 '23 16:10 jfienhold

As far as I know Amier is working on an NPM package to incorporate the form builder. To me this would be the right place to add such functionality.

apepper avatar Oct 23 '23 07:10 apepper

I adapted it to the Scrivito-Neoletter-Form-Widgets package and also reviewed it. The code appears to be in good shape, so perhaps you could approve it easily? Or perhaps someone else from your team could review it as well? I'm willing to take responsibility if any issues arise.

The situation is that there are existing customers who want that feature but aren't currently using the package. They've made some modifications to their form widgets that might not function properly if they switch to using the package.

aea-JR avatar Dec 12 '23 16:12 aea-JR

@aea-JR : Thank you for your offer. But I think it would be useful if:

  1. The example app uses scrivito-neoletter-form-widgets directly.
  2. scrivito-neoletter-form-widgets provides a way to customers/projects to provide custom code.

Could you create a PR that removes the existing form widgets from the example app and use scrivito-neoletter-form-widgets directly?

apepper avatar Jan 03 '24 12:01 apepper