webpack-external-import icon indicating copy to clipboard operation
webpack-external-import copied to clipboard

Published 20 hours ago • verified publisher icon ScriptedAlchemy

SyncWaterfallHook is not a constructor

Open katiawheeler opened this issue 5 years ago • 3 comments

Attempting to use this plugin. When I add the plugin to the webpack plugins, I get the following error when running webpack-dev-server:

TypeError: SyncWaterfallHook is not a constructor at URLImportPlugin.apply ...\node_modules\webpack-external-import\webpack\index.js:373:58

Any suggestions as to where to look?

katiawheeler avatar Feb 25 '20 19:02 katiawheeler

Looks like manually installing tapable solved this issue. Perhaps missing a peer dependency in 2.2.1?

katiawheeler avatar Feb 25 '20 21:02 katiawheeler

peerDependencies dont get installed, but rather warns in both npm and yarn afaik. Thinking this should be marked as a dependency.

It is strange that this issue occurred though. Webpack itself marks tapable as a dependency, and as this is a webpack plugin, this package should have resolved... Must be something else at play.

But none the less, we should resolve this.

maraisr avatar Feb 25 '20 21:02 maraisr

:tada: This issue has been resolved in version 2.2.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

ScriptedAlchemy avatar Feb 26 '20 07:02 ScriptedAlchemy