tlog icon indicating copy to clipboard operation
tlog copied to clipboard

Install tlog-rec-session with utmp group ownership

Open justin-stephenson opened this issue 4 years ago • 3 comments

Enables support for SGID update-utmp functionality implemented in https://github.com/Scribery/tlog/commit/60cc06f1b073eaa309422e135b4c5ac99f33c937

justin-stephenson avatar Jun 24 '20 14:06 justin-stephenson

Coverage Status

Coverage remained the same at 28.55% when pulling 2497325729d9cc745bc7ea5e54c8cd78c3e8d32c on justin-stephenson:utmp_update_group_owner into 60cc06f1b073eaa309422e135b4c5ac99f33c937 on Scribery:master.

coveralls avatar Jun 24 '20 14:06 coveralls

@casantos After thinking about this more, I would prefer to install and run tlog-rec-session with tlog:tlog ownership to run with the least amount of elevated privileges and maintain consistency with previous installs. I propose building with and adding support into tlog for https://github.com/altlinux/libutempter/ which installs with utmp group ownership and will minimize the amount of utmp/wtmp code we need to add into tlog. Unfortunately, I did not think about this earlier and therefore would likely need to revert https://github.com/Scribery/tlog/commit/60cc06f1b073eaa309422e135b4c5ac99f33c937

I can work on the libutempter changes but it may take some additional time, do you have any concerns with this approach?

justin-stephenson avatar Jun 24 '20 16:06 justin-stephenson

Hum, using libutempter looks like a good approach. Go ahead. I will read the documentation and try to contribute with an alternate solution.

casantos avatar Jun 24 '20 16:06 casantos