tlog icon indicating copy to clipboard operation
tlog copied to clipboard

Tlog-play receives input from recording

Open spbnick opened this issue 7 years ago • 2 comments

Apparently some recorded sessions can include control characters prompting the playback terminal to emulate input, which can then be interpreted by tlog-play as playback controls pausing or quitting the playback and potentially doing anything. An example could be a vim editing session.

I wasn't able to quickly find out how that happens exactly and how to deal with that, but we need to find it out and fix this. Perhaps check other playback programs for solutions.

spbnick avatar Dec 05 '17 13:12 spbnick

OK, no, what's likely is the recording asking the terminal for reports, and the playback terminal dutifully replying.

spbnick avatar Dec 05 '17 13:12 spbnick

It doesn't seem like we can stop the terminal from replying to the control sequences and we can't read the control keys from anywhere but the terminal. We should either filter out the request control sequences from the output or the response control sequences from the input, whichever is easier and more reliable.

The most reliable way, however, might be embedding a terminal emulator as #91 describes.

spbnick avatar Dec 05 '17 13:12 spbnick