Anthias icon indicating copy to clipboard operation
Anthias copied to clipboard

OOM and Github API error handling improvements

Open nkaminski opened this issue 2 years ago • 5 comments

This changeset improves behavior and recovery in 2 exceptional cases, namely:

  • When the viewer container reaches the configure memory limit and the OOM killer is invoked, the process that is typically killed in this case is the Chromium renderer process launched by QTWebEngine causing the viewer container to continue running but display a blank white screen. Therefore, this change increases the OOM score of the viewer container entrypoint script to the maximum value, guaranteeing that the viewer container is cleanly restarted after running OOM.

  • When the Github API is unavailable or the remote branch name currently checked out in Screenly's working directory does not exist upstream, the current implementation of the update check either causes a 500 error and/or rapid requests to the GitHub API. Therefore, this change also introduces backoff logic in the event that the remote Github branch status is not available.

nkaminski avatar Oct 02 '21 00:10 nkaminski

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarcloud[bot] avatar Oct 02 '21 00:10 sonarcloud[bot]

@vpetersson Would you mind adding a hacktoberfest-accepted label to this PR as well?

nkaminski avatar Oct 03 '21 00:10 nkaminski

@vpetersson Would you mind adding a hacktoberfest-accepted label to this PR as well?

Sure thing. Done.

vpetersson avatar Oct 04 '21 08:10 vpetersson

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jan 09 '22 03:01 stale[bot]

I noticed this is getting marked as stale, are we good to merge or is there's something you would like changed?

nkaminski avatar Mar 26 '22 23:03 nkaminski