Anthias
Anthias copied to clipboard
Screenly
Upgrade to Python 3
When we created Screenly OSE, Python 3 was still in its early days. Things have changed, and Python 2.7 is reaching EOL next year. It's time to start upgrading our code base to Python 3.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hello, I have ported a different project from 2 to 3 in the past and I had zero problems, though it was definitely much smaller. In #1045 you mention that it's partly due to dependencies. Have you already identified which dependencies are affected?
@ekevoo We'd love help with the upgrade to Python 3. Things have likely changed sin the initial comment in 1045, so I don't know if it is still the case. My gut feeling tells me that by now everything will work, and we will just need to refactor the code.
I might be able to help, but I just installed Screenly for the first time yesterday and haven't looked at the code yet. I guess the two big initial questions are
- What's the situation with unicode strings and byte strings? Are they marked (u"" and b"" or are there usually
from __future__ import unicode_literals)? - I notice the installer spends quite some time and effort clearing out any potential
python3and manually pullspip, which is what made me come look for this issue; is there an easy way to disable that? I don't want to have to wrestle with it for days.
What's the situation with unicode strings and byte strings? Are they marked (u"" and b"" or are there usually from future import unicode_literals)?
That's a good question - @rusko124?
I notice the installer spends quite some time and effort clearing out any potential python3 and manually pulls pip, which is what made me come look for this issue; is there an easy way to disable that? I don't want to have to wrestle with it for days.
Sure, that's done in here.
So I'm working at this today and I'm kind of puzzled on amf.py. I'm not sure what this does but it's clearly heavily encoding-related. I saw very few references to py2's str which is equivalent to py3's bytes.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@vpetersson Hey are you still interested in my help? My previous pull request is super stale and no longer usable, but I would appreciate if we could have a 30~60min meeting just to help me set up a testing environment so I can start over and build the PR in a way that the CI tools will be appeased.
@ekevoo as you might have seen, we've resurrected this project a bit lately. An engineer is about to start working on OSE and one of the first tasks will be to start working on the Python 3 migration. If you're still interested in helping out, please let us know.
Sure, no problem. Can I send you a calendar link privately? My Gmail username is the same as here.
Hello guys im trying to upgradeto python 3.9 on raspberry legacy 32 bit on pi 8gb but unfortunately i cant the reason its when i attempt to install screenly i receive this "could not find a version that satisfies the requirement ansible-core==2.12 " i read about it and in my understanding i must run python 3.9 , does any one faced that issue. Again its a Raspberian Legacy 32 bit /not lite version/
First, never use the Desktop version of Raspbian/Raspberry Pi OS with Screenly. It will not work.
Second, the error your facing sounds like you're still on the production branch. Switch over to master and this should be solved.
ok so somehow i was able to start the process under raspberian legacy but therefore i facing an error for could not find a version that satisfies the requirement ansible-core==2.12 and im looking in the link u send me there is nothing for that , when i tried to run it in lite version i cant get nowhere
On Fri, Oct 14, 2022 at 9:49 AM Viktor Petersson @.***> wrote:
First, never use the Desktop version of Raspbian/Raspberry Pi OS with Screenly. It will not work.
Second, the error your facing sounds like you're still on the production branch. Switch over to master and this should be solved.
— Reply to this email directly, view it on GitHub https://github.com/Screenly/screenly-ose/issues/1091#issuecomment-1279242044, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3TTAYM7POA7AUIF6YTK6DLWDGFKHANCNFSM4HI3UNTQ . You are receiving this because you commented.Message ID: @.***>
ok ill give it a shot just to confirm u want me to install the raspberry pi os legacy lite ?
No need for the legacy version. The latest (Bullseye Lite) should work just fine.
ill give it a try now , but i did yesterday and it did give me some error but ill try does steps that u send me Victor thx !
bash :/dev/fd/631: No such file or directory its the issue when i run it the way you said
Start with a new SD card and re-flash it from the start. Your installation or SD card is likely broken.
now im getting Sceenly OSE must be installed as the user pi with sudo premission when i type sudo i get the exat same error i gave it to ya ..
this is what it comes when I run the script
Based on the information, you're running Raspbian/Raspberry Pi OS Buster, not Bullseye. We haven't tested this on Buster.
#1743 was already merged. Closing this ticket now... Thanks, @vpetersson and @EliseAv for your help, especially for the references.
