android-slideshow icon indicating copy to clipboard operation
android-slideshow copied to clipboard

Upgrade Glide to v4

Open ScreamingHawk opened this issue 7 years ago • 3 comments

Glide is currently using v3.

Would be good to upgrade to v4. There is significant change for this.

ScreamingHawk avatar Dec 03 '17 18:12 ScreamingHawk

GifDrawable.getDecoder() is not available in Glide v4. This makes it difficult to calculate GIF run time for varying the slide delay when viewing a GIF.

Leaving this as a FIXME for now

ScreamingHawk avatar Dec 03 '17 19:12 ScreamingHawk

Performance change is negligible in the Android emulator. More testing required on device to see if this upgrade is a good idea.

ScreamingHawk avatar Dec 03 '17 19:12 ScreamingHawk

There's not really a good way to access the GifDecoder: https://stackoverflow.com/questions/47621960/glide-4-get-gifdecoder-of-gifdrawable

ScreamingHawk avatar Jan 09 '18 18:01 ScreamingHawk