website-v2
website-v2 copied to clipboard
Markdown strings shouldn't use their position in the file as keys
It means most of the file needs to be translated again after a change.
Yeah, I agree. I believe the website should use string keys, like the extension does.
Just enable TX identical string detection smh
I assume there isn't any way of changing the keys inside of MD. the TX setting will see if a key has already been translated before and if it has, users the past translation.
From: World_Languages @.> Sent: Saturday, July 17, 2021 12:47:06 PM To: ScratchAddons/website-v2 @.> Cc: Subscribed @.***> Subject: Re: [ScratchAddons/website-v2] Markdown strings shouldn't use their position in the file as keys (#89)
Yeah, I agree. I believe the website should use string keys, like the extension does.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/ScratchAddons/website-v2/issues/89#issuecomment-881934024, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOT5DESIBSWP223E5IPSQIDTYG6ZVANCNFSM5AL7FNTQ.
lol maybe skip my comment i didn't read this is about markdown but i've seen transifex using the string as the key for non-markdown, and i don't think that's very good?
but i've seen transifex using the string as the key for non-markdown, and i don't think that's very good?
It's much better than using line numbers. Markdown keys were like that too until recently.
I should have write this a while ago and I forgot, so here it goes now.
This is a Transifex problem on Markdown, and it's really weird that Transifex does that instead of your ordinary hashing or using the string directly. This is a limitation that I didn't expect.
Unless we move providers to something like Crowdin, maybe I should start thinking about doing a YAML/JSON dictionary instead. It builds a hash key from the all the valid strings, and similar strings would have the same key (This may be stupid). It may be worth it in the long run, or not, but I need to consider.
Forgot to comment it here, but I've since used TM Fillup so you don't need to rewrite exact texts that have been translated. I've tested it on FAQ, which I added admotions, which means the positions are changing, and no translation is thrown.
@Hans5958 That mitigated this issue, good enough I guess