ScratchAddons icon indicating copy to clipboard operation
ScratchAddons copied to clipboard

New Addon: Larger "Save Now" button

Open BroJac5246 opened this issue 2 years ago • 12 comments

Resolves #5189

Changes

Makes the "Save Now" button in the editor larger. Also includes a setting to determine if it should be highlighted (this is off by default because I want it to be unobtrusive since this addon is enabled by default).

I also updated some credits on other addons I worked on because I decided I want them to be different.

Screenshots: Before: Screenshot 2023-08-30 22 16 27

After: Screenshot 2023-08-30 22 16 58

After (with "Highlight on hover" enabled): Screenshot 2023-08-30 22 17 42

Reason for changes

This was highly requested and is useful to all users because the current "Save Now" button is quite small.

Tests

Tested on Chrome 115 on ChromeOS 115. This still needs testing on Firefox and ideally Edge.

BroJac5246 avatar Aug 31 '23 02:08 BroJac5246

Note: I was unable to get the setting to dynamically enable + disable. It's probably pretty simple, but I wasn't able to figure that out. If someone can help with that then that would be amazing :D

BroJac5246 avatar Aug 31 '23 02:08 BroJac5246

I've been super busy recently but I'll try to work on this over the weekend.

BroJac5246 avatar Sep 14 '23 12:09 BroJac5246

I don't think having the hover on by default is a problem.

Samq64 avatar Sep 14 '23 12:09 Samq64

I don't think having the hover on by default is a problem.

Do you think it makes more sense? I can turn it on if we decide that's better.

BroJac5246 avatar Sep 14 '23 17:09 BroJac5246

I don't think having the hover on by default is a problem.

I would personally enable it by default (and I'm not even sure if it should be an option!)

WorldLanguages avatar Sep 15 '23 02:09 WorldLanguages

May I push my suggestions?

Samq64 avatar Jan 26 '24 00:01 Samq64

May I push my suggestions?

Sure! I've been really busy recently but since you've made progress, go ahead.

BroJac5246 avatar Jan 26 '24 01:01 BroJac5246

Has it been decided if the highlight will be always enabled or not?

Samq64 avatar Jan 26 '24 03:01 Samq64

Has it been decided if the highlight will be always enabled or not?

4 people, including me, agreed that it makes sense, and no one disagreed, so I would say yes.

BroJac5246 avatar Jan 26 '24 03:01 BroJac5246

Has it been decided if the highlight will be always enabled or not?

I think enabling the highlight by default makes sense and seems like a good thing to bundle in this addon.

DNin01 avatar Jan 26 '24 03:01 DNin01

Will this be merged as soon as 1.36.0 releases? (Or maybe a little later if 1.36.1 comes out as well?)

BroJac5246 avatar Feb 15 '24 19:02 BroJac5246

This is going for v1.37.0 which shouldn't take long

WorldLanguages avatar Feb 18 '24 19:02 WorldLanguages

@WorldLanguages should this be merged?

BroJac5246 avatar Mar 09 '24 17:03 BroJac5246

This addon could have been a part of Customizable menu bar.

CST1229 avatar Mar 10 '24 14:03 CST1229

This addon could have been a part of Customizable menu bar.

See comments:

  • https://github.com/ScratchAddons/ScratchAddons/issues/5189#issuecomment-1663202919
  • https://github.com/ScratchAddons/ScratchAddons/issues/5189#issuecomment-1699636415

WorldLanguages avatar Mar 10 '24 15:03 WorldLanguages

This addon could have been a part of Customizable menu bar.

Then it couldn't be enabled by default.

Secret-chest avatar Mar 10 '24 17:03 Secret-chest

This addon could have been a part of Customizable menu bar.

Then it couldn't be enabled by default.

It could since all the optional are optional and disabled by default but you're right that most enabled by default addons don't have settings.

Samq64 avatar Mar 10 '24 18:03 Samq64

It could since all the optional are optional and disabled by default but you're right that most enabled by default addons don't have settings.

Addons with "Customizable" usually do nothing in the default state.

Secret-chest avatar Mar 11 '24 05:03 Secret-chest