ScratchAddons icon indicating copy to clipboard operation
ScratchAddons copied to clipboard

customizable link style: only affect non-obvious links

Open Secret-chest opened this issue 2 years ago • 20 comments

I would like to have some links underlined, but not all of them: I know I can click the navbar and footer links, the reply button, the forum post options, a forum post, project or comment username, a project or studio title, a post number, the account dropdown, tabbed navigation, see all, load more, pagination, breadcrumbs and probably more.

There should be an option to not modify the obvious links I mentioned earlier.

Secret-chest avatar Aug 18 '23 05:08 Secret-chest

This seems difficult to do objectively.

mybearworld avatar Aug 18 '23 06:08 mybearworld

This seems difficult to do objectively.

Basically not user-generated links.

Secret-chest avatar Aug 18 '23 06:08 Secret-chest

What if you haven't learned that those elements are links? A person born colorblind wouldn't know any better unless they hovered over the links.

DNin01 avatar Aug 19 '23 23:08 DNin01

What if you haven't learned that those elements are links? A person born colorblind wouldn't know any better unless they hovered over the links.

This would be an option, if you want to discover more links just don't enable this.

Secret-chest avatar Aug 20 '23 20:08 Secret-chest

This would be an option, if you want to discover more links just don't enable this.

Isn't the whole point of this addon right now to make links more distinguishable?

Samq64 avatar Aug 20 '23 20:08 Samq64

Isn't the whole point of this addon right now to make links more distinguishable?

Once you know what things in the site layout you can click on, you don't need any cues. This is not true for links in comments, descriptions and forum posts.

Secret-chest avatar Aug 20 '23 21:08 Secret-chest

Isn't the whole point of this addon right now to make links more distinguishable?

Once you know what things in the site layout you can click on, you don't need any cues. This is not true for links in comments, descriptions and forum posts.

If we wanted to get really specific, technically, forum posts are the only issue for someone who knows all of the built-in links, since forum posts can have links with custom text, whereas comments and descriptions can't.

I think it makes a lot more sense to just consistently highlight all links rather than just user-generated ones.

DNin01 avatar Aug 20 '23 21:08 DNin01

Why is it that important to have the option to only highlight non-obvious links, anyway?

DNin01 avatar Aug 20 '23 21:08 DNin01

Taking what I said further, I think it makes the most sense to just highlight links all around. That's the whole point of this addon. Having confidence that links are bold or underlined everywhere can help with recognizing them and remembering the style. I mean, really imagine how it would feel to use Scratch and only being able to tell by memory where any of the links are (which you can simulate with dark-www).

For those without colorblindness, they would either enable the addon as a preference or leave it off. For colorblind users, the most important thing is that links are distinguishable from normal text, so for convenience, someone would most likely want all links to be styled at any cost to how things look. I don't think an in-between really matters.

DNin01 avatar Aug 20 '23 21:08 DNin01

Just wanted to say that I don't think we've received any feedback related to this addon, at least for now.

WorldLanguages avatar Aug 20 '23 22:08 WorldLanguages

Why is it that important to have the option to only highlight non-obvious links, anyway?

Too much lines creates visual clutter.

Secret-chest avatar Aug 21 '23 04:08 Secret-chest

Why is it that important to have the option to only highlight non-obvious links, anyway?

Too much lines creates visual clutter.

I know. From a perspective of someone who isn't colorblind, excessive underlines can seem overwhelming.

You know what, maybe there are some places we can not underline text, however I think it still makes sense to have most links that are mixed with normal text to be highlighted. How about this, we highlight all links except for project titles and the usernames below them and basically any link with a clickable image next to it, some button-like links such as the reply button, a few others, and maybe footer links.

DNin01 avatar Aug 21 '23 19:08 DNin01

You know what, maybe there are some places we can not underline text, however I think it still makes sense to have most links that are mixed with normal text to be highlighted. How about this, we highlight all links except for project titles and the usernames below them and basically any link with a clickable image next to it, some button-like links such as the reply button, a few others, and maybe footer links.

Possibly view all, forum post options, post headers, tabs, pagination and breadcrumbs too, but otherwise fine.

Secret-chest avatar Aug 21 '23 19:08 Secret-chest

Why is it that important to have the option to only highlight non-obvious links, anyway?

Too much lines creates visual clutter.

I know. From a perspective of someone who isn't colorblind, excessive underlines can seem overwhelming.

This is almost certainly true for colorblind people as well, they just recognize that the clutter is ultimately beneficial. However, it's still clutter, and ideally it would be minimal if possible.

BroJac5246 avatar Aug 21 '23 22:08 BroJac5246

Just wanted to say that I don't think we've received any feedback related to this addon, at least for now.

Nevermind:

i LOVE SA's, all the customizable options make it the best scratch extension ever! anyways, here's accessibility suggestions for the link highlight addon and more: a way to customize the color of the underline, and an addon that adds accessiBe integration, this will help EVERYONE that uses scratch, but has terrible vision. you can message me on both usernames on the top if you think these are great suggestions.

Well, not very helpful.

WorldLanguages avatar Aug 21 '23 22:08 WorldLanguages

So, underline color and "accessible integration"? Underline color would actually be helpful as you could change the transparency of them to make it ultimately have less visual clutter.

mybearworld avatar Aug 22 '23 07:08 mybearworld

GitHub just added an experimental link underlines setting in Accessibility settings. They said it only affects links in text blocks, which includes links in user-generated content. Maybe we could draw some inspiration from it?

DNin01 avatar Oct 02 '23 01:10 DNin01

Basically, exclude action links, navigation and thumbnail links.

Secret-chest avatar Feb 17 '24 21:02 Secret-chest

I am interested in making this a default behavior. My idea with how to keep the underline style rules in a single file is to use a CSS variable that uses a solid underline when you choose to underline all links and is used to remove implicit links' underlines otherwise. Kind of like this:

/* Obvious links */
#footer a, .thumbnail a /* etc. */ {
  text-decoration: var(--colorblind-underlineAllSetting);
}

/* All other links */
a, input a /* etc. */ {
  text-decoration: solid;
}

DNin01 avatar Feb 17 '24 23:02 DNin01

If you need a list...

  • Navbar
  • Footer
  • Breadcrumbs (all forms)
  • Pagination (all forms)
  • View all
  • Forum username
  • Anything styled like a button
  • Project, user and studio thumbnail labels
  • Comment username
  • Comment reply link
  • Forum post options
  • Anything styled like tabs

Secret-chest avatar Feb 19 '24 13:02 Secret-chest