ScratchAddons icon indicating copy to clipboard operation
ScratchAddons copied to clipboard

Create "Highlight mentions" addon

Open mybearworld opened this issue 2 years ago • 7 comments

Resolves #6185

Changes

Add "Highlight mentions" addon.

Reason for changes

This would make it easier to see mentions of your username.

Tests

Tested on Edge.

mybearworld avatar Jun 17 '23 15:06 mybearworld

Non-theme addons generally shouldn't have color settings. Most people won't change the color and it makes it impossible to change it automatically based on dark mode settings. See #1262

mxmou avatar Jun 17 '23 19:06 mxmou

Non-theme addons generally shouldn't have color settings. Most people won't change the color and it makes it impossible to change it automatically based on dark mode settings. See #1262

Non-theme addons such as editor-stepping and paint-snap still have customizable colors.

I was thinking of having this option in mentions mainly to make it possible to choose between Scratch's default blue/purple color or a shade of yellow/orange, like the one used for mentions on GitHub. But if the goal is not to have too many customizations, sure, I guess we don't need it, but we should choose between a shade of yellow/orange or Scratch's default colors.

DNin01 avatar Jun 17 '23 19:06 DNin01

I want to control my colours.

Secret-chest avatar Jun 18 '23 07:06 Secret-chest

I was thinking of having this option in mentions mainly to make it possible to choose between Scratch's default blue/purple color or a shade of yellow/orange, like the one used for mentions on GitHub. But if the goal is not to have too many customizations, sure, I guess we don't need it, but we should choose between a shade of yellow/orange or Scratch's default colors.

If that was the intention, could an orange color from Scratch's color palette (maybe the Variables color - #FF8C1A) be the default?

mxmou avatar Jun 18 '23 08:06 mxmou

I was thinking of having this option in mentions mainly to make it possible to choose between Scratch's default blue/purple color or a shade of yellow/orange, like the one used for mentions on GitHub. But if the goal is not to have too many customizations, sure, I guess we don't need it, but we should choose between a shade of yellow/orange or Scratch's default colors.

If that was the intention, could an orange color from Scratch's color palette (maybe the Variables color - #FF8C1A) be the default?

The colors will probably have changed by the time of the release of the next version, so the color would be #ffa54c.

mybearworld avatar Jun 18 '23 10:06 mybearworld

I was thinking of having this option in mentions mainly to make it possible to choose between Scratch's default blue/purple color or a shade of yellow/orange, like the one used for mentions on GitHub. But if the goal is not to have too many customizations, sure, I guess we don't need it, but we should choose between a shade of yellow/orange or Scratch's default colors.

If that was the intention, could an orange color from Scratch's color palette (maybe the Variables color - #FF8C1A) be the default?

The colors will probably have changed by the time of the release of the next version, so the color would be #ffa54c.

The original colors will still be the default.

mxmou avatar Jun 18 '23 11:06 mxmou

I was thinking of having this option in mentions mainly to make it possible to choose between Scratch's default blue/purple color or a shade of yellow/orange, like the one used for mentions on GitHub. But if the goal is not to have too many customizations, sure, I guess we don't need it, but we should choose between a shade of yellow/orange or Scratch's default colors.

If that was the intention, could an orange color from Scratch's color palette (maybe the Variables color - #FF8C1A) be the default?

The colors will probably have changed by the time of the release of the next version, so the color would be #ffa54c.

The original colors will still be the default.

Oh, yeah, I completely forgot about that

mybearworld avatar Jun 18 '23 11:06 mybearworld

@mybearworld deleting your fork caused all your PRs to be closed. Was that intentional?

Samq64 avatar Dec 01 '24 14:12 Samq64

@mybearworld deleting your fork caused all your PRs to be closed. Was that intentional?

Oh! Thank you for letting me know! I meant to delete some other forks, not this one.

mybearworld avatar Dec 01 '24 15:12 mybearworld

I accidentally deleted my fork. New PR is at #7971

mybearworld avatar Dec 01 '24 15:12 mybearworld