ScratchAddons icon indicating copy to clipboard operation
ScratchAddons copied to clipboard

Customizable block palette opacity

Open mxmou opened this issue 3 years ago • 3 comments

Changes

Allows the opacity of the block palette to be changed using editor dark mode. All presets use the default 80%. Migration code will be needed to add transparency to existing settings.

Reason for changes

I don't think there is a good reason to not make it customizable.

mxmou avatar Jul 28 '22 10:07 mxmou

Good idea! This should be customizable

WorldLanguages avatar Jul 30 '22 21:07 WorldLanguages

@apple502j Please review my changes to get-addon-settings.js Is it safe to remove the old transition code? Or do we still need to set addonSettings["editor-dark-mode"]._version = 2 if it's not yet defined?

WorldLanguages avatar Jul 30 '22 21:07 WorldLanguages

@WorldLanguages Read the comment on that file

apple502j avatar Jul 31 '22 08:07 apple502j

Or do we still need to set addonSettings["editor-dark-mode"]._version = 2 if it's not yet defined?

Yes

apple502j avatar Aug 13 '22 01:08 apple502j

#4817 changed the transition code to better handle no-op transition.

apple502j avatar Aug 13 '22 08:08 apple502j